Skip to content

Pod Quadlet can configure podman pod stop --time #27250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pod Quadlet can configure podman pod stop --time #27250

wants to merge 2 commits into from
+23 −2

Conversation

nimdrak
Copy link
Contributor

@nimdrak nimdrak commented Oct 8, 2025

Fixed #27120

Does this PR introduce a user-facing change?

None

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nimdrak
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nimdrak nimdrak changed the title Pod Quadlet can't configure podman pod stop --time Pod Quadlet can configure podman pod stop --time Oct 8, 2025
@jankaluza
Copy link
Member

I think you will also have to document this in https://github.com/containers/podman/blob/main/docs/source/markdown/podman-systemd.unit.5.md

@nimdrak
Copy link
Contributor Author

nimdrak commented Oct 8, 2025

@jankaluza Thanks. I missed the point. I'll do that soon.

@nimdrak nimdrak force-pushed the 27120 branch 2 times, most recently from f93e444 to 007d3b8 Compare October 8, 2025 10:38
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@nimdrak nimdrak marked this pull request as draft October 8, 2025 13:27
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025
ygalblum
ygalblum reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Small nit

ygalblum
ygalblum reviewed Oct 8, 2025
View reviewed changes
@nimdrak nimdrak force-pushed the 27120 branch 2 times, most recently from e168bec to 7b2c32b Compare October 8, 2025 14:52
@nimdrak nimdrak force-pushed the 27120 branch 2 times, most recently from 3bea0d8 to 36089d5 Compare October 8, 2025 14:55
@nimdrak nimdrak marked this pull request as ready for review October 8, 2025 14:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025
@ygalblum
Copy link
Contributor

ygalblum commented Oct 8, 2025

You have some trailing whitespace in podman-systemd.unit.5.md

@nimdrak
Update docs for StopTimeOut
e3c9fa6 
Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Copy link
Contributor Author

nimdrak commented Oct 9, 2025

@ygalblum Thanks for letting me know it. I fixed it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygalblum ygalblum ygalblum left review comments

Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pod Quadlet can't configure podman pod stop --time
3 participants
@nimdrak @jankaluza @ygalblum